Adding risk data model validation to integration testing#387
Merged
Conversation
pyth0n1c
previously approved these changes
Apr 29, 2025
|
|
||
| # Suppress logging by default; enable for local testing | ||
| ENABLE_LOGGING = False | ||
| ENABLE_LOGGING = True |
Contributor
There was a problem hiding this comment.
I am going to switch this to False.
But we should probably consider exposing ALL logging and verbosity as a common setting somewhere (possibly in contentctl.yml or the command line) since as we add more and more of it, it can be extremely useful
Also bump contentctl version for new release
pyth0n1c
approved these changes
Apr 29, 2025
Contributor
pyth0n1c
left a comment
There was a problem hiding this comment.
I made two additional small changes to bump the version and disable logging.
Given those are small changes, I will approve and merge myself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Code changes
CorrelationSearchclass which retrieves events from the risk data modelTesting
TODOs